feat(connector): [Recurly] Add record back support for recurly [V2] #7544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
aniketburman014
force-pushed
the
recurly_record_back
branch
from
af2d0d3 to
5c37952
Compare
aniketburman014
changed the title
Comment on lines
612
to
618
| Ok(format!( | ||
| "{}/invoices/{}/{}", | ||
| self.base_url(connectors), | ||
| invoice_id, | ||
| status_endpoint | ||
| )) | ||
| } |
There was a problem hiding this comment.
Suggested change
| Ok(format!( | |
| "{}/invoices/{}/{}", | |
| self.base_url(connectors), | |
| invoice_id, | |
| status_endpoint | |
| )) | |
| } | |
| Ok(format!( | |
| "{}/invoices/{invoice_id}/{status_endpoint}", | |
| self.base_url(connectors) | |
| )) | |
| } |
Comment on lines
310
to
311
| // inovice id | ||
| pub id: common_utils::id_type::PaymentReferenceId, |
There was a problem hiding this comment.
Suggested change
| // inovice id | |
| pub id: common_utils::id_type::PaymentReferenceId, | |
| // inovice id | |
| pub id: id_type::PaymentReferenceId, |
Comment on lines
600
to
605
| let status = RecurlyRecordStatus::try_from(req.request.attempt_status).map_err(|_| { | ||
| errors::ConnectorError::NotSupported { | ||
| message: "Invalid attempt status for Recurly".to_string(), | ||
| connector: "recurly", | ||
| } | ||
| })?; |
There was a problem hiding this comment.
is this map_err required ?
Comment on lines
608
to
609
| RecurlyRecordStatus::Success => "mark_successful", | ||
| RecurlyRecordStatus::Failure => "mark_failed", |
There was a problem hiding this comment.
Can we have this string as global variables ?
hyperswitch-bot
bot
added
the
M-api-contract-changes
srujanchikke
approved these changes
Mar 20, 2025
aniketburman014
added
api-v2
A-connector-integration
ShankarSinghC
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add support for record back flow for recurly.
What is record back flow ?
After payment is retried by revenue recovery, we need to update the billing processor invoice.
Recurly flow
We record the transaction in recurly created by internal system. This transaction will automatically update the invoice status in recurly system.
Additional Changes
Motivation and Context
How did you test it?
This can only be tested in local since the entire recovery flow is not complete. Tested locally by triggering the connector integration manually.
Here are the local testing logs :
Checklist
cargo +nightly fmt --allcargo clippy