-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): Make payment_method_subtype optional in payment_attempt [V2] #7568
Open
AnuthaDev
wants to merge
3
commits into
main
Choose a base branch
from
optional-subtype
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swangi-kumari
previously approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed connector files.
Chethan-rao
previously approved these changes
Mar 19, 2025
jarnura
requested changes
Mar 19, 2025
0448a3b
Narayanbhat166
previously approved these changes
Mar 20, 2025
swangi-kumari
previously approved these changes
Mar 20, 2025
Chethan-rao
previously approved these changes
Mar 20, 2025
jarnura
previously approved these changes
Mar 20, 2025
94e22e7
swangi-kumari
approved these changes
Mar 21, 2025
Narayanbhat166
approved these changes
Mar 21, 2025
Chethan-rao
approved these changes
Mar 21, 2025
jarnura
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-core
Area: Core flows
api-v2
M-api-contract-changes
Metadata: This PR involves API contract changes
M-database-changes
Metadata: This PR involves database schema changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
payment_method_subtype
Nullable inpayment_attempt
tablepayment_method_subtype
anOption
in request and response structsAdditional Changes
Motivation and Context
Closes #7567
How did you test it?
Response:
Checklist
cargo +nightly fmt --all
cargo clippy