feat(connector): [TRUSTPAY] implement Banktransfer PaymentMethod #7575

swangi-kumari · 2025-03-19T12:47:08Z

Type of Change

Description

Implement Banktransfer PaymentMethod

SepabankTransfer
InstantBankTransfer

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Create a Merchant Account
Create API Key
Create MCA for Trustpay

curl --location 'http://localhost:8080/account/merchant_1742393217/connectors' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: test_admin' \
--data '{
  "connector_type": "payment_processor",
  "connector_name": "trustpay",
  "connector_account_details": {
    "auth_type": "SignatureKey",
    "api_key": "_/",
    "key1": "_",
    "api_secret": "_"
  },
  "test_mode": false,
  "disabled": false,
  "payment_methods_enabled": [
    {
            "payment_method": "bank_transfer",
            "payment_method_types": [
                {
                    "payment_method_type": "sepa",
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_type": "instant_bank_transfer",
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
                
            ]
        },
        {
            "payment_method": "card",
            "payment_method_types": [
                {
                    "payment_method_type": "credit",
                    "card_networks": [
                        "AmericanExpress",
                        "Discover",
                        "Interac",
                        "JCB",
                        "Mastercard",
                        "Visa",
                        "DinersClub",
                        "UnionPay",
                        "RuPay"
                    ],
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_type": "debit",
                    "card_networks": [
                        "AmericanExpress",
                        "Discover",
                        "Interac",
                        "JCB",
                        "Mastercard",
                        "Visa",
                        "DinersClub",
                        "UnionPay",
                        "RuPay"
                    ],
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        },
        {
            "payment_method": "bank_redirect",
            "payment_method_types": [
                {
                    "payment_method_type": "giropay",
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_type": "eps",
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_type": "sofort",
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_type": "ideal",
                    "recurring_enabled": true,
                    "installment_payment_enabled": true,
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "payment_experience": "redirect_to_url"
                },
                {
                    "payment_method_type": "blik",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_type": "trustly",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        }
  ],
  "metadata":{
    "currency_id": 1,
    "platform_id": 6,
    "ledger_account_id": "__"
  }
}'

Create a SepaBankTransfer Request

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_qvBkR76d1dON9WyPNxtZWeulmuwqqF5Rw6Cm8qOkKbvl8rdAqaDpc7U59iD91A1s' \
--data-raw '
{
  "amount": 6540,
  "currency": "EUR",
  "confirm": true,
  "capture_method": "automatic",
  "capture_on": "2022-09-10T10:11:12Z",
  "amount_to_capture": 6540,
  "customer_id": "StripeCustomer",
  "email": "[email protected]",
  "name": "John Doe", 
  "phone": "999999999",
  "phone_country_code": "+1",
  "description": "Its my first payment request",
  "authentication_type": "three_ds",
  "return_url": "https://google.com",
    "payment_method": "bank_transfer",
  "payment_method_type" :"sepa",
  "payment_method_data": {
    "bank_transfer": {
      "sepa_bank_transfer": {  }
    }
  },
  "statement_descriptor_name": "joseph",
  "statement_descriptor_suffix": "JS",
  "metadata": {
    "udf1": "value1",
    "new_customer": "true",
    "login_date": "2019-09-10T10:11:12Z"
  },
  "billing": {
    "address": {
      "line1": "1467",
      "line2": "Harrison Street",
      "line3": "Harrison Street",
      "city": "San Fransico",
      "state": "California",
      "zip": "94122",
      "country": "US",
      "first_name": "joseph",
      "last_name": "Doe"
    },
    "phone": {
      "number": "8056594427",
      "country_code": "+91"
    }
  },
  "shipping": {
    "address": {
      "line1": "1467",
      "line2": "Harrison Street",
      "line3": "Harrison Street",
      "city": "San Fransico",
      "state": "California",
      "zip": "94122",
      "country": "US",
      "first_name": "joseph",
      "last_name": "Doe"
    },
    "phone": {
      "number": "8056594427",
      "country_code": "+91"
    }
  },
  "browser_info": {
        "user_agent": "Mozilla\/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/70.0.3538.110 Safari\/537.36",
        "accept_header": "text\/html,application\/xhtml+xml,application\/xml;q=0.9,image\/webp,image\/apng,*\/*;q=0.8",
        "language": "nl-NL",
        "color_depth": 24,
        "screen_height": 723,
        "screen_width": 1536,
        "time_zone": 0,
        "java_enabled": true,
        "java_script_enabled": true,
        "ip_address": "125.0.0.1"
    }
}'

Response

{"payment_id":"pay_YfpkgBLtlfxzUos4hHkv","merchant_id":"merchant_1742380281","status":"requires_customer_action","amount":6540,"net_amount":6540,"shipping_cost":null,"amount_capturable":6540,"amount_received":null,"connector":"trustpay","client_secret":"pay_YfpkgBLtlfxzUos4hHkv_secret_Erf90NQm5lsQ6ump6oVu","created":"2025-03-19T10:31:33.360Z","currency":"EUR","customer_id":"StripeCustomer","customer":{"id":"StripeCustomer","name":"John Doe","email":"[email protected]","phone":"999999999","phone_country_code":"+1"},"description":"Its my first payment request","refunds":null,"disputes":null,"mandate_id":null,"mandate_data":null,"setup_future_usage":null,"off_session":null,"capture_on":null,"capture_method":"automatic","payment_method":"bank_transfer","payment_method_data":{"bank_transfer":{"sepa":{}},"billing":null},"payment_token":null,"shipping":{"address":{"city":"San Fransico","country":"US","line1":"1467","line2":"Harrison Street","line3":"Harrison Street","zip":"94122","state":"California","first_name":"joseph","last_name":"Doe"},"phone":{"number":"8056594427","country_code":"+91"},"email":null},"billing":{"address":{"city":"San Fransico","country":"US","line1":"1467","line2":"Harrison Street","line3":"Harrison Street","zip":"94122","state":"California","first_name":"joseph","last_name":"Doe"},"phone":{"number":"8056594427","country_code":"+91"},"email":null},"order_details":null,"email":"[email protected]","name":"John Doe","phone":"999999999","return_url":"https://google.com/","authentication_type":"three_ds","statement_descriptor_name":"joseph","statement_descriptor_suffix":"JS","next_action":{"type":"redirect_to_url","redirect_to_url":"http://localhost:8080/payments/redirect/pay_YfpkgBLtlfxzUos4hHkv/merchant_1742380281/pay_YfpkgBLtlfxzUos4hHkv_1"},"cancellation_reason":null,"error_code":null,"error_message":null,"unified_code":null,"unified_message":null,"payment_experience":null,"payment_method_type":"sepa","connector_label":null,"business_country":null,"business_label":"default","business_sub_label":null,"allowed_payment_method_types":null,"ephemeral_key":{"customer_id":"StripeCustomer","created_at":1742380293,"expires":1742383893,"secret":"epk_1411d0f87da9476ea1e9cf8b1aab84d7"},"manual_retry_allowed":null,"connector_transaction_id":"3147675683","frm_message":null,"metadata":{"udf1":"value1","login_date":"2019-09-10T10:11:12Z","new_customer":"true"},"connector_metadata":null,"feature_metadata":null,"reference_id":null,"payment_link":null,"profile_id":"pro_Dpn1IlkqQ72qlQrX54yK","surcharge_details":null,"attempt_count":1,"merchant_decision":null,"merchant_connector_id":"mca_bJYyAFiGqhhJhlr3BpCe","incremental_authorization_allowed":null,"authorization_count":null,"incremental_authorizations":null,"external_authentication_details":null,"external_3ds_authentication_attempted":false,"expires_on":"2025-03-19T10:46:33.360Z","fingerprint":null,"browser_info":{"language":"nl-NL","time_zone":0,"ip_address":"125.0.0.1","user_agent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36","color_depth":24,"java_enabled":true,"screen_width":1536,"accept_header":"text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8","screen_height":723,"java_script_enabled":true},"payment_method_id":null,"payment_method_status":null,"updated":"2025-03-19T10:31:34.479Z","split_payments":null,"frm_metadata":null,"extended_authorization_applied":null,"capture_before":null,"merchant_order_reference_id":null,"order_tax_amount":null,"connector_mandate_id":null,"card_discovery":null,"issuer_error_code":null,"issuer_error_message":null}

Create a InstantBankTransfer Payment

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_qvBkR76d1dON9WyPNxtZWeulmuwqqF5Rw6Cm8qOkKbvl8rdAqaDpc7U59iD91A1s' \
--data-raw '
{
  "amount": 6540,
  "currency": "EUR",
  "confirm": true,
  "capture_method": "automatic",
  "capture_on": "2022-09-10T10:11:12Z",
  "amount_to_capture": 6540,
  "customer_id": "StripeCustomer",
  "email": "[email protected]",
  "name": "John Doe", 
  "phone": "999999999",
  "phone_country_code": "+1",
  "description": "Its my first payment request",
  "authentication_type": "three_ds",
  "return_url": "https://google.com",
    "payment_method": "bank_transfer",
  "payment_method_type" :"instant_bank_transfer",
  "payment_method_data": {
    "bank_transfer": {
      "instant_bank_transfer": {  }
    }
  },
  "statement_descriptor_name": "joseph",
  "statement_descriptor_suffix": "JS",
  "metadata": {
    "udf1": "value1",
    "new_customer": "true",
    "login_date": "2019-09-10T10:11:12Z"
  },
  "billing": {
    "address": {
      "line1": "1467",
      "line2": "Harrison Street",
      "line3": "Harrison Street",
      "city": "San Fransico",
      "state": "California",
      "zip": "94122",
      "country": "SK",
      "first_name": "joseph",
      "last_name": "Doe"
    },
    "phone": {
      "number": "8056594427",
      "country_code": "+91"
    }
  },
  "shipping": {
    "address": {
      "line1": "1467",
      "line2": "Harrison Street",
      "line3": "Harrison Street",
      "city": "San Fransico",
      "state": "California",
      "zip": "94122",
      "country": "SK",
      "first_name": "joseph",
      "last_name": "Doe"
    },
    "phone": {
      "number": "8056594427",
      "country_code": "+91"
    }
  },
  "browser_info": {
        "user_agent": "Mozilla\/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/70.0.3538.110 Safari\/537.36",
        "accept_header": "text\/html,application\/xhtml+xml,application\/xml;q=0.9,image\/webp,image\/apng,*\/*;q=0.8",
        "language": "nl-NL",
        "color_depth": 24,
        "screen_height": 723,
        "screen_width": 1536,
        "time_zone": 0,
        "java_enabled": true,
        "java_script_enabled": true,
        "ip_address": "125.0.0.1"
    }
}'

Response

{"payment_id":"pay_OSdcJIXIcFFySqWm7FZ3","merchant_id":"merchant_1742385527","status":"requires_customer_action","amount":6540,"net_amount":6540,"shipping_cost":null,"amount_capturable":6540,"amount_received":null,"connector":"trustpay","client_secret":"pay_OSdcJIXIcFFySqWm7FZ3_secret_hmkqdAMHQ2PpObgTgIfc","created":"2025-03-19T12:02:02.266Z","currency":"EUR","customer_id":"StripeCustomer","customer":{"id":"StripeCustomer","name":"John Doe","email":"[email protected]","phone":"999999999","phone_country_code":"+1"},"description":"Its my first payment request","refunds":null,"disputes":null,"mandate_id":null,"mandate_data":null,"setup_future_usage":null,"off_session":null,"capture_on":null,"capture_method":"automatic","payment_method":"bank_transfer","payment_method_data":{"bank_transfer":{"instant_bank_transfer":{}},"billing":null},"payment_token":null,"shipping":{"address":{"city":"San Fransico","country":"US","line1":"1467","line2":"Harrison Street","line3":"Harrison Street","zip":"94122","state":"California","first_name":"joseph","last_name":"Doe"},"phone":{"number":"8056594427","country_code":"+91"},"email":null},"billing":{"address":{"city":"San Fransico","country":"US","line1":"1467","line2":"Harrison Street","line3":"Harrison Street","zip":"94122","state":"California","first_name":"joseph","last_name":"Doe"},"phone":{"number":"8056594427","country_code":"+91"},"email":null},"order_details":null,"email":"[email protected]","name":"John Doe","phone":"999999999","return_url":"https://google.com/","authentication_type":"three_ds","statement_descriptor_name":"joseph","statement_descriptor_suffix":"JS","next_action":{"type":"redirect_to_url","redirect_to_url":"http://localhost:8080/payments/redirect/pay_OSdcJIXIcFFySqWm7FZ3/merchant_1742385527/pay_OSdcJIXIcFFySqWm7FZ3_1"},"cancellation_reason":null,"error_code":null,"error_message":null,"unified_code":null,"unified_message":null,"payment_experience":null,"payment_method_type":"instant_bank_transfer","connector_label":null,"business_country":null,"business_label":"default","business_sub_label":null,"allowed_payment_method_types":null,"ephemeral_key":{"customer_id":"StripeCustomer","created_at":1742385722,"expires":1742389322,"secret":"epk_fb63b0b5ff5d4b09bec618b213434452"},"manual_retry_allowed":null,"connector_transaction_id":"5968676728","frm_message":null,"metadata":{"udf1":"value1","login_date":"2019-09-10T10:11:12Z","new_customer":"true"},"connector_metadata":null,"feature_metadata":null,"reference_id":null,"payment_link":null,"profile_id":"pro_GKgBVFZG1sYIeDDTTFht","surcharge_details":null,"attempt_count":1,"merchant_decision":null,"merchant_connector_id":"mca_LYv7UDOEKVo9ISDI4vYh","incremental_authorization_allowed":null,"authorization_count":null,"incremental_authorizations":null,"external_authentication_details":null,"external_3ds_authentication_attempted":false,"expires_on":"2025-03-19T12:17:02.266Z","fingerprint":null,"browser_info":{"language":"nl-NL","time_zone":0,"ip_address":"125.0.0.1","user_agent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36","color_depth":24,"java_enabled":true,"screen_width":1536,"accept_header":"text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8","screen_height":723,"java_script_enabled":true},"payment_method_id":null,"payment_method_status":null,"updated":"2025-03-19T12:02:03.526Z","split_payments":null,"frm_metadata":null,"extended_authorization_applied":null,"capture_before":null,"merchant_order_reference_id":null,"order_tax_amount":null,"connector_mandate_id":null,"card_discovery":null,"issuer_error_code":null,"issuer_error_message":null}

Complete payment using redirection link.
payment will be in processing step.

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2025-03-19T12:47:10Z

Review changes with

Changed Files

File	Status
crates/common_enums/src/connector_enums.rs	93% smaller
crates/hyperswitch_connectors/src/connectors/zsl/transformers.rs	88% smaller
crates/api_models/src/payments.rs	61% smaller
crates/hyperswitch_connectors/src/connectors/adyen.rs	60% smaller
crates/hyperswitch_connectors/src/connectors/trustpay.rs	53% smaller
crates/hyperswitch_connectors/src/connectors/itaubank/transformers.rs	36% smaller
crates/hyperswitch_connectors/src/connectors/klarna.rs	35% smaller
crates/hyperswitch_connectors/src/connectors/paypal/transformers.rs	32% smaller
crates/hyperswitch_connectors/src/connectors/adyen/transformers.rs	26% smaller
crates/hyperswitch_connectors/src/connectors/shift4/transformers.rs	26% smaller
crates/hyperswitch_connectors/src/connectors/zen/transformers.rs	26% smaller
crates/router/src/connector/stripe/transformers.rs	22% smaller
crates/euclid/src/frontend/dir/transformers.rs	16% smaller
crates/kgraph_utils/src/transformers.rs	15% smaller
crates/router/src/types/transformers.rs	12% smaller
api-reference-v2/openapi_spec.json	8% smaller
api-reference/openapi_spec.json	8% smaller
crates/hyperswitch_connectors/src/connectors/trustpay/transformers.rs	1% smaller
config/config.example.toml	Unsupported file format
config/deployments/integration_test.toml	Unsupported file format
config/deployments/production.toml	Unsupported file format
config/deployments/sandbox.toml	Unsupported file format
config/development.toml	Unsupported file format
config/docker_compose.toml	Unsupported file format
crates/api_models/src/payments/additional_info.rs	0% smaller
crates/common_enums/src/enums.rs	0% smaller
crates/common_enums/src/transformers.rs	0% smaller
crates/connector_configs/toml/development.toml	Unsupported file format
crates/connector_configs/toml/production.toml	Unsupported file format
crates/connector_configs/toml/sandbox.toml	Unsupported file format
crates/euclid/src/frontend/dir/enums.rs	0% smaller
crates/euclid/src/frontend/dir/lowering.rs	0% smaller
crates/hyperswitch_connectors/src/utils.rs	0% smaller
crates/hyperswitch_domain_models/src/payment_method_data.rs	0% smaller
crates/kgraph_utils/src/mca.rs	0% smaller
crates/router/src/configs/defaults/payment_connector_required_fields.rs	0% smaller
crates/router/src/connector/utils.rs	0% smaller
crates/router/src/core/payments/helpers.rs	0% smaller
loadtest/config/development.toml	Unsupported file format

sai-harsha-vardhan · 2025-03-21T10:55:02Z

crates/api_models/src/payments.rs

@@ -3383,6 +3384,10 @@ pub enum BankTransferData {
    LocalBankTransfer {
        bank_code: Option<String>,
    },
+    InstantBankTransfer {
+        /// The billing details for Instant Bank Transfer
+        billing_details: Option<DokuBillingDetails>,


This is not required right?

deepanshu-iiitu · 2025-03-21T12:10:31Z

crates/hyperswitch_connectors/src/connectors/trustpay/transformers.rs

+            name: get_full_name(params.billing_first_name, billing_last_name),
+            email: item.request.get_email()?,


Add these fields to crates/router/src/configs/defaults/payment_connector_required_fields.rs

Also test if email is passed if we pass it in billing.email

I have added required fields.

feat: implement banktransfer for trustpay

e93ab9c

swangi-kumari added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes labels Mar 19, 2025

swangi-kumari self-assigned this Mar 19, 2025

swangi-kumari requested review from a team as code owners March 19, 2025 12:47

feat: wasm

6a7112b

sai-harsha-vardhan reviewed Mar 21, 2025

View reviewed changes

deepanshu-iiitu requested changes Mar 21, 2025

View reviewed changes

swangi-kumari and others added 3 commits March 23, 2025 19:11

refactor: add sepabanktrasfer pmt

08e6e69

Merge branch 'main' into trustpay-bank-transfer

c7b95c9

docs(openapi): re-generate OpenAPI specification

fe4dfa0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(connector): [TRUSTPAY] implement Banktransfer PaymentMethod #7575

feat(connector): [TRUSTPAY] implement Banktransfer PaymentMethod #7575

swangi-kumari commented Mar 19, 2025 •

edited

Loading

semanticdiff-com bot commented Mar 19, 2025 •

edited

Loading

sai-harsha-vardhan Mar 21, 2025

deepanshu-iiitu Mar 21, 2025

deepanshu-iiitu Mar 21, 2025

swangi-kumari Mar 23, 2025

		name: get_full_name(params.billing_first_name, billing_last_name),
		email: item.request.get_email()?,

feat(connector): [TRUSTPAY] implement Banktransfer PaymentMethod #7575

Are you sure you want to change the base?

feat(connector): [TRUSTPAY] implement Banktransfer PaymentMethod #7575

Conversation

swangi-kumari commented Mar 19, 2025 • edited Loading

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

semanticdiff-com bot commented Mar 19, 2025 • edited Loading

sai-harsha-vardhan Mar 21, 2025

Choose a reason for hiding this comment

deepanshu-iiitu Mar 21, 2025

Choose a reason for hiding this comment

deepanshu-iiitu Mar 21, 2025

Choose a reason for hiding this comment

swangi-kumari Mar 23, 2025

Choose a reason for hiding this comment

swangi-kumari commented Mar 19, 2025 •

edited

Loading

semanticdiff-com bot commented Mar 19, 2025 •

edited

Loading