feat(core): add redis lock during insertion of event in event table during initial attempt of outgoing webhook delivery #7579
+36
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
The current implementation of insertion of an event in
event
table does not handle the case where multiple requests with the same idempotent_event_id might be processed concurrently, leading to multiple unique constraint violation errors in the database.This was reported by a merchant who was facing high volumes of unique constraint violation errors.
NOTE: this unique constraint log error issue is only applicable for the
initial
attempt of outgoing webhook delivery, not for retry attemptsWhy does this happen?
idempotent_event_id
might reach the database at the same time.Solution (Using Redis Lock)
Before querying the database, acquire a lock in Redis for the given idempotent_event_id.
Only one process/thread will hold the lock, preventing others from inserting at the same time.
If a lock is acquired:
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy