Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(themes): Add email configuration support for themes #7580

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kanikabansal-juspay
Copy link
Contributor

@kanikabansal-juspay kanikabansal-juspay commented Mar 20, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added changes for the emails as per the email theme config.
Changes are done for:

  • verify.html
  • reset.html
  • invite.html
  • magic_link.html

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

To add theme customisation to email templates.

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@kanikabansal-juspay kanikabansal-juspay added the S-in-progress Status: Implementation is underway label Mar 20, 2025
@kanikabansal-juspay kanikabansal-juspay self-assigned this Mar 20, 2025
@kanikabansal-juspay kanikabansal-juspay requested review from a team as code owners March 20, 2025 13:09
Copy link

semanticdiff-com bot commented Mar 20, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/services/email/assets/reset.html  81% smaller
  crates/router/src/services/email/assets/invite.html  80% smaller
  crates/router/src/services/email/assets/magic_link.html  80% smaller
  crates/router/src/services/email/assets/verify.html  78% smaller
  crates/router/src/services/email/types.rs  31% smaller
  config/development.toml Unsupported file format
  crates/router/src/consts/user.rs  0% smaller
  crates/router/src/core/user.rs  0% smaller

@kanikabansal-juspay kanikabansal-juspay added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-in-progress Status: Implementation is underway labels Mar 21, 2025
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Mar 21, 2025
@kanikabansal-juspay kanikabansal-juspay added S-in-progress Status: Implementation is underway and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Mar 21, 2025
@hyperswitch-bot hyperswitch-bot bot removed the M-api-contract-changes Metadata: This PR involves API contract changes label Mar 21, 2025
</head>


<body style="
background-color: #f8f9fb;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass background color as well. Check other templates as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-in-progress Status: Implementation is underway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(themes): theme customisation for email templates Email Config Support for themes
2 participants