Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): update base URLs for connectors in production #7584

Closed
wants to merge 3 commits into from

Conversation

Arunmadhavan28
Copy link

@Arunmadhavan28 Arunmadhavan28 commented Mar 20, 2025

📌 Type of Change

  • Bugfix
  • New feature
  • [X ] Enhancement
  • [ X] Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

📝 Description
Updated config/deployments/production.toml by replacing demo/test/sandbox base_url with live/production URLs.
Ensured all affected connectors now use the correct live URLs.

Closes #7583
Fixes #7582
Closes #6981

🛠️ Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • [ X] This PR modifies application configuration/environment variables

📂 Affected config files:

config/deployments/production.toml
💡 Motivation and Context

Some connectors were using incorrect URLs in production, leading to misconfigured deployments.
This PR ensures the correct live URLs are used for proper functionality.
🔗 Related Issue: #7583

✅ How did you test it?

Verified the changes manually by checking the updated URLs.
Ensured there are no syntax errors in production.toml.
📋 Checklist

  • [ X] I formatted the code cargo +nightly fmt --all
  • [ X] I addressed lints thrown by cargo clippy
  • [X ] I reviewed the submitted code
  • I added unit tests for my changes where possible

@Arunmadhavan28 Arunmadhavan28 requested a review from a team as a code owner March 20, 2025 17:50
Copy link

semanticdiff-com bot commented Mar 20, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  api-reference-v2/openapi_spec.json  0% smaller
  api-reference/openapi_spec.json  0% smaller
  config/deployments/production.toml Unsupported file format
  cypress.config.js  0% smaller
  cypress/e2e/sample_test.cy.js  0% smaller
  cypress/fixtures/example.json  0% smaller
  cypress/screenshots/sample_test.cy.js/My First Test -- Visits the app (failed).png Unsupported file format
  cypress/support/commands.js  0% smaller
  cypress/support/e2e.js  0% smaller
  package-lock.json Unsupported file format
  package.json  0% smaller

@Arunmadhavan28 Arunmadhavan28 changed the title [REFACTOR] Update prod config file with live/prod base URLs of connec… refactor(config): update production base URLs for connectors Mar 20, 2025
@Arunmadhavan28 Arunmadhavan28 changed the title refactor(config): update production base URLs for connectors refactor(config): update base URLs for connectors in production Mar 20, 2025
@Arunmadhavan28 Arunmadhavan28 requested a review from a team as a code owner March 20, 2025 19:13
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Mar 20, 2025
Copy link
Author

@Arunmadhavan28 Arunmadhavan28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the changes. Let me know if any modifications are needed

@Arunmadhavan28 Arunmadhavan28 deleted the fix-7583 branch March 22, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use MinorUnit for Novalnet Amount [REFACTOR] update prod config file with live/prod base url of connectors
1 participant