ci(cypress): do not overwrite metadata during mca update call

[arindam-sahoo]

Type of Change

• Bugfix
• New feature
• Enhancement
• Refactoring
• Dependency updates
• Documentation
• CI/CD

Description

The Connector Update Body is being overwritten, which included the metadata as well. Due to this, if there were any required metadata fields of a connector, then the Connector Update Test would fail.

For example, Braintree connector has a required metadata field, and while testing the Connector Update, just because it was being overwritten by the update-connector-body.json fixture, the test fails as shown in the following screenshot.

Additional Changes

• This PR modifies the API contract
• This PR modifies the database schema
• This PR modifies application configuration/environment variables

Motivation and Context

While adding the Card test Flows for the Braintree connector, the Connector Update Test Failed.

How did you test it?

Running the 0000-CoreFlows.cy.js for Braintree connector

Checklist

• I formatted the code cargo +nightly fmt --all
• I addressed lints thrown by cargo clippy
• I reviewed the submitted code
• I added unit tests for my changes where possible

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
cypress-tests/cypress/fixtures/update-connector-body.json	34% smaller

[pixincreate]

how does this change actually fixes things?

when creating the mca, auth is read that includes metadata. and you're passing it. unless the update call nullifies the metadata that is passed in the create call, update call shouldn't fail at all.

i can see that we're overwriting the metadata while making the update call.

try removing the metadata object from cypress-tests/cypress/fixtures/update-connector-body.json and see if that helps.

[arindam-sahoo]

Yup, right. My bad, didn't even think that it may be because of the fixtures, making changes.

[arindam-sahoo]

Changes are done in 0f3bb51 and reverted back the wrongly made changes in 9e61292