-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(users): refactor ProdIntent
to support product-type context and merchant-scope
#7638
Open
tsdk02
wants to merge
14
commits into
main
Choose a base branch
from
prod-intent-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
ProdIntent
to support product-type context and merchant-scope
ThisIsMani
reviewed
Mar 27, 2025
SanchithHegde
previously approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR introduces support for associating ProdIntent with specific product_types and transitions the feature from being user-scoped to merchant-scoped, enabling more flexible usage across different products.
Changes Introduced
1. New V2 Routes for Dashboard Metadata
ProdIntent
creation and retrieval with respect toproduct_type
.2. Product-Type Context for ProdIntent
ProdIntent
into thedashboard_metadata
table (for both v1 and v2 schemas), theproduct_type
is now included in the metadata.3. Merchant-Scoped ProdIntent
ProdIntent
was user-scoped, allowing a single request per user.ProdIntent
requests for different merchant accounts for each product by the same user.4. Enhanced Email Body
ProdIntent
now includes theproduct_type
context, helping understand for which product the prod intent was raised.Additional Changes
Motivation and Context
Enable requesting for Production Access for every product type merchant account.
How did you test it?
Hit the curl:
Dashboard Metadata table should get inserted/updated with the record along with the product_type in the json body.

Sample entry to table:
Also, product_type should also be sent in the email body to the configured recepient email-id.

Expected Output:
Similarly v2 routes:
http://localhost:8080/v2/user/data
(POST)http://localhost:8080/v2/user/data?keys=ProdIntent
(GET)Checklist
cargo +nightly fmt --all
cargo clippy