feat(process_tracker): Invoke record back flow in PCR workflow [V2] #7660
+237
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
srujanchikke
commented
Mar 28, 2025
Comment on lines
+91
to
+97
| let billing_mca = store | ||
| .find_merchant_connector_account_by_id( | ||
| key_manager_state, | ||
| &billing_merchant_connector_account_id, | ||
| &pcr_data.key_store, | ||
| ) | ||
| .await?; |
There was a problem hiding this comment.
Note : We cannot avoid db call here since we need connector creds to make record back. Get MCA will not give api keys to call connector.
jarnura
requested changes
Mar 29, 2025
| @@ -49,7 +50,8 @@ impl< | |||
| + api::FraudCheckV2 | |||
| + api::ConnectorMandateRevokeV2 | |||
| + api::authentication_v2::ExternalAuthenticationV2 | |||
| + api::UnifiedAuthenticationServiceV2, | |||
| + api::UnifiedAuthenticationServiceV2 | |||
| + api::revenue_recovery_v2::RevenueRecoveryV2, | |||
There was a problem hiding this comment.
Suggested change
| + api::revenue_recovery_v2::RevenueRecoveryV2, | |
| + api::revenue_recovery::RevenueRecovery, |
jarnura
previously approved these changes
Apr 1, 2025
| @@ -49,7 +50,8 @@ impl< | |||
| + api::FraudCheckV2 | |||
| + api::ConnectorMandateRevokeV2 | |||
| + api::authentication_v2::ExternalAuthenticationV2 | |||
| + api::UnifiedAuthenticationServiceV2, | |||
| + api::UnifiedAuthenticationServiceV2 | |||
| + api::revenue_recovery_v2::RevenueRecoveryV2, | |||
Aprabhat19
previously approved these changes
Apr 1, 2025
| ) -> Result<(), errors::ProcessTrackerError> { | ||
| let db = &*state.store; | ||
| let db: &dyn StorageInterface = &*state.store; |
There was a problem hiding this comment.
nit: Can you remove this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
What is record back flow ?
After payment is retried by revenue recovery by PCR workflow, We need to update the billing processor(update the invoce or record the attempt).This PR invokes record back functionality in process tracker flow for Terminal status.
Note: Adding support for retrying failed outgoing recordback webhooks is still pending attached in this issues.
Additional Changes
Motivation and Context
How did you test it?
Can be tested once this PR is merged #7614
Checklist
cargo +nightly fmt --allcargo clippy