fix: resolve CI test-build import NameError for SyncStreamResponse#31
Merged
Merged
Conversation
TYPE_CHECKING-only imports are not defined at runtime; unquoted return annotations on BaseProvider.stream and Completion.create overload caused NameError when loading the installed wheel. CI test-build failed on import. Use string forward references so annotations are not evaluated eagerly. Co-authored-by: Darshan Harihar <DarshanHarihar1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Test Build CI job installs the built wheel and runs
python -c "import justllms". That step failed on all Python versions becauseSyncStreamResponsewas only imported underTYPE_CHECKING, whileBaseProvider.stream()and aCompletion.create()overload still used it as a runtime return annotation. Python evaluates those annotations when defining the class, which raisedNameError: name 'SyncStreamResponse' is not defined.Changes
justllms/core/base.py: use a string forward reference for thestream()return type ("SyncStreamResponse").justllms/core/completion.py: same for the@overloadbranch that returns a stream.Verification
Locally:
ruff check justllms/,black --check justllms/,mypy justllms/ --ignore-missing-imports, thenpython -m build, installdist/*.whlinto a cleanPYTHONPATH, andimport justllmssucceeds.