fix: handle empty YAML and JSON config files#32
Merged
Conversation
Empty config files make yaml.safe_load and json.load return None, which caused Config.from_file to raise TypeError. Treat null/empty documents as an empty mapping and reject non-mapping top-level values. Co-authored-by: Darshan Harihar <DarshanHarihar1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Loading an empty
justllms.yaml/justllms.ymlor a JSON file containing onlynullcausedConfig.from_file()to crash withTypeError: argument after ** must be a mapping, not NoneType, becauseyaml.safe_load()andjson.load()returnNonefor those inputs.This change treats
null/empty documents as an empty configuration mapping (same as{}) and raises a clearValueErrorwhen the top-level document is not a mapping (for example, a YAML list).Changes
Config.from_file()now normalizesNoneto{}before constructingConfigValueErrorwith a descriptive messageTesting
Ran the full CI workflow locally:
ruff check justllms/black --check justllms/mypy justllms/ --ignore-missing-importspython -m build+ wheel import smoke testVerified manually:
.yaml→ returnsConfig()with default empty providers.jsoncontainingnull→ same behaviorValueError