fix: populate tools_used when execute_tools is False#35
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
When the model returns tool calls but automatic execution is disabled, tools_used was left unset. Populate it from the requested tool call names so callers can inspect which tools the model intended to invoke. Co-authored-by: Darshan Harihar <DarshanHarihar1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the model returns tool calls but automatic execution is disabled (
execute_tools=False),CompletionResponse.tools_usedwas left unset (None). Callers that inspecttools_usedto see which tools the model requested could not rely on that field unless tools were actually executed.Changes
tools_usedfrom the extracted tool call names when returning early without execution.Testing
Local CI checks passed:
ruff check justllms/black --check justllms/mypy justllms/ --ignore-missing-importspython -m buildNote
The same fix is also on branch
darshan/fix-tools-used-without-executionper repo automation conventions.