fix(ios): propagate simulator command failures - #184
Draft
justrach wants to merge 1 commit into
Draft
Conversation
Owner
Author
|
CI note: the windows-cross-compile failure is inherited from current main (main run 26505539517 is also red). It occurs in generated QuickJS bindings for kuri-fetch with two unused local constants, before the iOS mobile code is compiled, and is unrelated to this two-file screenshot-status patch. The native build-and-test and startup-smoke jobs pass; locally, kuri-mobile builds with pinned Zig 0.16.0, passes 10/10 tests, and both physical-style CLI reproductions exit 3 without creating a file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
kuri-mobile captured the raw simctl termination status but all simulator operations discarded it. Passing a physical-device UDID to the default simulator path therefore returned 0 even though simctl rejected the device and wrote no file.
Validation
Closes justrach/codegraff#265