feat: improve depends_on in workspace steps#87
Open
bongnv wants to merge 2 commits intojwplayer:masterfrom
Open
feat: improve depends_on in workspace steps#87bongnv wants to merge 2 commits intojwplayer:masterfrom
bongnv wants to merge 2 commits intojwplayer:masterfrom
Conversation
bongnv
commented
Apr 1, 2022
| golang.org/x/sys v0.0.0-20190422165155-953cdadca894 h1:Cz4ceDQGXuKRnVBDTS23GTn/pU5OE2C0WrNTOYK1Uuc= | ||
| golang.org/x/sys v0.0.0-20190422165155-953cdadca894/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= | ||
| golang.org/x/sys v0.0.0-20220330033206-e17cdc41300f h1:rlezHXNlxYWvBCzNses9Dlc7nGFaNMJeqLolcmQSSZY= | ||
| golang.org/x/sys v0.0.0-20220330033206-e17cdc41300f/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= |
Author
There was a problem hiding this comment.
Needs to update golang.org/x/sys for the project to work with Go 1.18. (ref)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if a workspace step depends on a project step, the plugin will generate an incorrect pipeline. For example:
depends_onintagstep won't be updated intobuild:project1andbuild:project2.This PR aims to improve this behaviour. Please take a look at the test to see how it will be updated.
Note:
make qualitystops working with the latest version ofgolangci-lintso I added.golangci.yamland updates some code to fix some lint error.