Adds git push template for python webapp2 with google_app_engine sdk #48
Conversation
|
@jin09 Thanks for the PR! I've never used the jetbrains python IDE before, but I don't think we should be committing the Also, can you include a I'll test it out in the meanwhile :) |
|
I have now included the |
|
Hi, |
python-webapp2/Dockerfile
Outdated
|
|
||
| RUN pip install -r /home/src/requirements.txt | ||
|
|
||
| CMD ["python", "/home/google_appengine/dev_appserver.py", "/home/src/app.yaml", "--skip_sdk_update_check=yes", "--host", "0.0.0.0", "--port", "8080"] |
There was a problem hiding this comment.
You can create an app directory instead of putting the source code in /home. That way it will be cleaner.
python_webapp2_vanilla/Dockerfile
Outdated
|
|
||
| RUN pip install -r /home/src/requirements.txt | ||
|
|
||
| CMD ["python", "/home/src/main.py"] |
There was a problem hiding this comment.
Same with having an app directory instead of putting it in /home.
There was a problem hiding this comment.
Also, in the directory name of vanilla webapp2 use hyphens instead of underscore (as every other folder is hyphenated). So python-webapp2-vanilla instead of python_webapp2_vanilla.
python_webapp2_vanilla/main.py
Outdated
| @@ -0,0 +1,16 @@ | |||
| import webapp2 | |||
|
|
|||
There was a problem hiding this comment.
The requirements.txt is empty. Are you sure it doesn't need webapp2?
There was a problem hiding this comment.
No it doesn't need webapp2 since it is already installed in the custom base Image that I have built for this (jin09/webapp2)
…ith hyphens in folder name
|
I have made a few changes, please review them. |
|
@jin09 Sorry for being totally AWOL on this. |
|
@coco98 Workflow for local develoment is in the Dockerfile recipe itself. Or is there anything specific that you want me to add? |
Added git push template for python webapp2. Tested on hasura local dev setup