FE: Fix blocked public assets (#1038) #1040
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make?
Added all remaining assets in the
frontend/public
folder to the list of objects that can be viewed unauthenticated. Fixes #1038.Is there anything you'd like reviewers to focus on?
I couldn't figure out how to fix the issue with the logout page, but it is so minor that it can also be ignored. If you have suggestions, let me know and I'll include them in the PR.
How Has This Been Tested?
Why have you not tested your change?
Due to licensing, I can't use docker-desktop but instead use colima. I have tried for the past two hours to get things to work and I can get a build to finish as long as I don't try to build docker images.
I keep getting "Connection refused" when the container tries to connect to localhost. I have ended up on these two seemingly useful comments, but they didn't work for me.
I don't understand Colima or Docker well enough to figure out how to enable the localhost connection. If someone has a way to help me get the environment set up, I'll happily give it a shot and test my own PR.
Otherwise, if you are able to test my PR, please let me know whether it resolved the linked issue. 🙏
Checklist (put an "x" next to all the items, otherwise the build will fail)
A picture of a cute animal (not mandatory but encouraged)
