refactor: for nonce avoid base64 padding with '=' #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
force-pushed
the
251023-avoid-base64-padding-in-scram-nonce
branch
from
b0b7e10 to
bc26c94
Compare
'=' is technically not forbidden and it worked just fine with Kafka since day 1, but it could potentially become an issue maybe in the future for some other Kafka API compatible server.
zmstone
force-pushed
the
251023-avoid-base64-padding-in-scram-nonce
branch
from
bc26c94 to
5b59d00
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 80.24% 80.32% +0.07%
==========================================
Files 21 21
Lines 1726 1733 +7
==========================================
+ Hits 1385 1392 +7
Misses 341 341 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thalesmg
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'=' is technically not forbidden and it worked just fine with Kafka since day 1, but it could potentially become an issue maybe in the future for some other Kafka API compatible server.