Skip to content

upgrade to Kanela 2.0.0-beta.1 #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ivantopo
Copy link
Contributor

@ivantopo ivantopo commented Apr 7, 2025

For the most part this is the exact same functionality we had already but now using Kanela 2.0 instead. A few important things to mention:

  • This PR drops support for Scala 2.11 and 2.12
  • This PR also drops support for Akka 2.5 and Play 2.6. Some instrumentation might work but we are not going to be testing it or providing support for it anymore
  • We are now using slf4j 2.0, which for almost everyone will just mean upgrading their logback versions as well. This will only be a problem for people using Spring Boot 2.7 or earlier with Kamon who can try adding the org.springframework.boot.logging.LoggingSystem=none system property as we did in our tests, or try to upgrade to Spring Boot 3, or just keep using Kamon 2.7.x. I don't think there will be a lot of effort from our side on the Spring instrumentation because Micrometer already does a much better work with the instrumentation. Any future efforts will probably be focused on interop rather than rewriting instrumentation in Kamon
  • All the within and exclude patters are now matched using a simple string prefix instead of regex, so they had to be updated all over the place
  • The executors instrumentation no longer has the ability to use custom wrappers for Runnable/Callables submitted to the executors. I'm not sure if anyone ever used this feature but we were not using it in Kamon so it got removed
  • This release still works with Java 8, but it is likely that we will drop support for Java 8 and require at least Java 17 in the soon to come Kamon 3.0

@ivantopo ivantopo force-pushed the upgrade-to-kanela-2 branch 2 times, most recently from a47d236 to 35c6e28 Compare April 7, 2025 12:13
@ivantopo ivantopo force-pushed the upgrade-to-kanela-2 branch from 35c6e28 to c7a5e97 Compare April 7, 2025 14:58
@ivantopo ivantopo marked this pull request as ready for review April 7, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant