Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the most part this is the exact same functionality we had already but now using Kanela 2.0 instead. A few important things to mention:
org.springframework.boot.logging.LoggingSystem=none
system property as we did in our tests, or try to upgrade to Spring Boot 3, or just keep using Kamon 2.7.x. I don't think there will be a lot of effort from our side on the Spring instrumentation because Micrometer already does a much better work with the instrumentation. Any future efforts will probably be focused on interop rather than rewriting instrumentation in Kamonwithin
andexclude
patters are now matched using a simple string prefix instead of regex, so they had to be updated all over the placeRunnable/Callable
s submitted to the executors. I'm not sure if anyone ever used this feature but we were not using it in Kamon so it got removed