Add change_output_type to StreamDeserializer#25
Open
dr-bonez wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
change_output_typemethod toStreamDeserializerthat lets you switch the deserialization target type without rebuilding the deserializer or losing your position in the stream.Motivation
When reading a CBOR stream that contains a mix of different types (e.g. a header followed by a sequence of records), you currently have to create a new
StreamDeserializerfor each type you want to read. Since theTparameter onStreamDeserializeris only used as aPhantomDatamarker, there's no reason you shouldn't be able to swap it out on the fly.This comes up in practice when you have a framed protocol or file format where different sections of the stream have different schemas. Without this, you end up having to drop down to
serde_cbor_2::Valueand convert manually, or do awkward workarounds with the reader.