feat: Add SaxHandler for testing SAX parsers #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since it's not very helpful in snapshots
karfau
added a commit
to karfau/xmldom
that referenced
this pull request
Jan 25, 2021
to see if we would be able to replace it. Currently running jest tests also runs those tests, which adds a snapshot file for 530 valid XML cases. I'm thinking about improving the output format (in xmltest), so it's easier to compare (on a per file basis?) TODOs: - `startDocument`/`endDocument` are currently not reported - `lib/sax.js` does access some internals of domBuilder that are not present on `SaxHandler` from xmltest, which might lead to `error`s being reported. karfau/xmltest#11
and `replaceWhiteSpaceChars`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.