implement optimistic hide for resource and policy deletions#397
implement optimistic hide for resource and policy deletions#397RafsanNeloy wants to merge 4 commits into
Conversation
Signed-off-by: rafsanneloy <rafsanneloy@gmail.com>
Summary of ChangesHello @RafsanNeloy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience of the dashboard by introducing an "optimistic hide" mechanism for resource and policy deletion operations. Instead of waiting for a full data refresh from the backend, items are now immediately removed from the UI upon receiving a successful deletion response from the API. This change provides instant visual feedback to the user, making the application feel more responsive and fluid during common management tasks. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces an optimistic UI update for resource and policy deletions, which is a great enhancement for user experience. When an item is deleted, it's immediately hidden from the view instead of waiting for a data refresh. The implementation is consistent across multiple pages. My review includes suggestions to improve code conciseness, reduce duplication, and enhance readability, which will contribute to better maintainability.
|
/assign |
Signed-off-by: rafsanneloy <rafsanneloy@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Adding label DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I added getPolicyKey for more convenient in base.ts to avoid marge conflict. |
What type of PR is this?
/kind design
What this PR does / why we need it: Improves UI responsiveness by immediately hiding resources from the dashboard after a successful deletion response, instead of waiting for background sync or manual reloads.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: