removes the function "playFreqM2M" #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wrote that function to do the startup tones before I understood how callbacks worked, and I was confused by how they worked. The code I'm merging here is from the "testextension" repo, and it works fine in doing the startup tones.
add other port name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote that function on the "testextension" repo to do the startup tones before I understood how callbacks worked, and I was confused in making a function with them. The code I'm merging here is from a more recent version of our "testextension" repo, and it works fine in doing the startup tones.
I don't think this changes anything performance-wise, as it's basically doing the same thing. It's more of a housekeeping thing - it's pointless to have a specific function that's the same as another but without a callback.