Add re_interpolate groups()#516
Merged
Merged
Conversation
silentbicycle
requested changes
Jan 26, 2026
june-fastly
reviewed
Jan 26, 2026
| * re_interpolate_groups() ahead of time with groupc = 0 | ||
| * and passing a non-NULL nonexistent value. | ||
| * | ||
| * The output string will always be less than or equal in |
Owner
Author
There was a problem hiding this comment.
You're right, I forgot half my sentence
Spotted by both June and Scott, thanks
Suggested by Scott
june-fastly
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renders out a simple format string with escapes that hopefully suit group capture.
We don't have group capture, but it seems topical for the library.
As usual I've deferred any decisions to the caller. In particular I kept
group0passed separately because I don't want to require someone to construct an array containing that element prefixed to an existing array of captured values.