Skip to content

Fix MacOS x64 builds + TODO / typo cleanup #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrCreosote merged 2 commits into from
Mar 3, 2026
Merged

Fix MacOS x64 builds + TODO / typo cleanup #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70fbbfc
Minor TODO / typo cleanup
MrCreosote Mar 3, 2026
180d2c6
Fix macos x64 builds
MrCreosote Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/native_binary_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
label: linux-x64
- os: macos-14
label: macos-arm64
- os: macos-13
- os: macos-15-intel
label: macos-x64

runs-on: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/native_binary_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
label: linux-x64
- os: macos-14
label: macos-arm64
- os: macos-13
- os: macos-15-intel
label: macos-x64

runs-on: ${{ matrix.os }}
Expand Down
8 changes: 1 addition & 7 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,11 @@ plugins {
id 'org.graalvm.buildtools.native' version '0.10.6'
}

// TODO BUILD look into GraalVM native compilation vs. dockerizing kb-sdk
// https://github.com/oracle/graal/issues/407#issuecomment-2573704305
// TODO GENSCRIPT need to update genscript if we don't switch to GraalVM. Need to release to get
// a latest tag

// TODO TEST DEPS TypeGeneratorTest has a hard coded list of jars it uses for tests
// Need to figure out a better way
// TODO TEST add a test that starts the SDK in a docker container and checks some simple cmds
// TODO DEPS make JitPack jars for catalog and NMS and use them

// TODO CODE move all code under us.kbase.sdk
// EDIT - run against the kb-sdk+ binary

group = 'us.kbase.sdk'

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/us/kbase/sdk/callback/CallbackServerManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public class CallbackServerManager implements AutoCloseable {
* @param workDirRoot the working directory for the callback server. This directory will
* be mounted into the server. Any files outside of this directory will not be visible to
* the server. The callback server will write output here.
* @param kbaseBaseUrl the base URL for contacting kBase services,
* @param kbaseBaseUrl the base URL for contacting KBase services,
Copy link
Member Author

@MrCreosote MrCreosote Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AT LONG LAST #193 (review)

* e.g. "https://ci.kbase.us/services/"
* @param token the user's KBase token for contacting KBase services.
* @param prov initial provenance for the callback server.
Expand Down
Loading