URO-352 Fix checkbox inputs not actually getting a default value set when it should#3698
Open
URO-352 Fix checkbox inputs not actually getting a default value set when it should#3698
Conversation
|
Member
Author
|
Apparently, according to the tests, this was by design. That feels like a mistake - if that box is checked, it should send values as though it's checked. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3698 +/- ##
===========================================
- Coverage 25.94% 25.89% -0.05%
===========================================
Files 461 461
Lines 46662 46663 +1
===========================================
- Hits 12106 12084 -22
- Misses 34556 34579 +23
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description of PR purpose/changes
A little case that occurs in the following combined conditions:
What this will do is keep the incorrect value and pass it along to the app, potentially causing all manner of chaos (or minor headaches).
The warning says that the checkbox value being set is the default. While that happens visually, it doesn't actually affect the data model until the user clicks the little 'x' to close the warning.
This forces the data model to set the value to the default on input widget load.
Jira Ticket / Issue
Related Jira ticket: https://kbase-jira.atlassian.net/browse/URO-352
Testing Instructions
Dev Checklist:
formatandcheckon changed Python code manually or with a git precommit hookUpdating Version and Release Notes (if applicable)