Skip to content

[WIP] Add test for wire serializers #3415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[WIP] Add test for wire serializers #3415

wants to merge 3 commits into from

Conversation

ntnn
Copy link
Member

@ntnn ntnn commented May 19, 2025 •
edited
Loading

Summary

See kcp-dev/code-generator#100 and kcp-dev/code-generator#99

This is like 90% to prove that the serializers work out of the box. If we want an e2e test to prevent future breaking I'd add some kcp-specific interactions.

What Type of PR Is This?

/kind documentation

Related Issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. dco-signoff: yes Indicates the PR's author has signed the DCO. labels May 19, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xrstf for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 19, 2025
@ntnn ntnn mentioned this pull request May 19, 2025
Closed
@ntnn ntnn force-pushed the serializers_test branch from 9e2477e to 3ec8b3c Compare May 19, 2025 21:15
@ntnn
Add test for serializers
4c96b39 
Signed-off-by: Nelo-T. Wallus <[email protected]>
@ntnn ntnn force-pushed the serializers_test branch from 3ec8b3c to 4c96b39 Compare May 19, 2025 22:06
@ntnn
Add kcp-specific code
785d09c 
Signed-off-by: Nelo-T. Wallus <[email protected]>
@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 19, 2025
@ntnn
skip protobuf for kcp
3d9971e 
Signed-off-by: Nelo-T. Wallus <[email protected]>
@ntnn
Copy link
Member Author

ntnn commented May 19, 2025

/retest

@ntnn ntnn closed this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntnn @kcp-ci-bot