BIG-168 Add retries for GoogleClient #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirkasemmler
force-pushed
the
jirka-big-168-retry
branch
from
bec3aef to
4537b7a
Compare
jirkasemmler
force-pushed
the
jirka-big-168-retry
branch
from
fb3ec64 to
522473e
Compare
jirkasemmler
requested review from
a team and
zajca
and removed request for
a team
zajca
requested changes
Oct 10, 2023
| // try max 3 times | ||
| 'retries' => 3, | ||
| // multiplicator of backoff time between runs. First = $initial_delay ; second $previousDelay * $factor | ||
| 'factor' => 1.1, |
There was a problem hiding this comment.
hmm mohlo to byt lineární, ale je tam ten jitter, který to može posunůt před tů minutu takže asi cajk.
| $this->cleanTestProject(); | ||
| } | ||
|
|
||
| public function testCreateManyServiceACounts(): void |
There was a problem hiding this comment.
asi bych to dal mark as skip, je to zbytečné imho to pokaždé půšťat
zajca
approved these changes
Oct 10, 2023
|
upravil sem tu test metodu, nemá to žádné dobré řešení phpstan/phpstan-phpunit#52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://keboola.atlassian.net/browse/BIG-168
Google_clientma nejakou retry policy nastavenou. Kdyz se do nich prokliknes, tak je tam neco jako'clientConfig' => __DIR__ . '/../resources/cloud_billing_client_config.json',, kde ten json obsahuje nejakou retry policy na ruzne metody. Do toho jsem nechtel uplne stouratGoogle_client, ktery ho nema a resi nam to problem zakladani SAGoogle\Task\Runnerpridas na lajnu 187 neco takovehoecho time() . " executing #{$this->attempts} / {$this->maxAttempts} \n";tak uvidis jak to pekne dela retryDEFAULT_RETRY_SETTINGSmam tak nejak od oka. Vime, ze potrebujeme cekat cca 60s, takze delay je 60s, factor jsem dal jen 1.1 aby to moc exponencialne nerostlo a jitter taky malinkatej