Ntfy notification support #747
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 31, 2023 17:07
Extending templates and values for new Env Variable NTFY_WEBHOOK_URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes adds support for native NTFY notifications.
Here is a screenshot of the notification in NTFY:
The upper notification was triggered via this new implementation. The below one is triggered by the already existing webhook notification.
This change also makes the necessary additions to the helm chart values and template.
Unit tests are created and fine.
Disclaimer: i did not get the e2e Tests to work, however i am pretty sure that this is due to an issue with my setup. I am getting the following fail during the e2e Test:
--- FAIL: TestPollingPrivateRegistry (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x4b7c11]
Additinally the e2e tests do not seem to finish. The change is not related to the private registry polling so i suspect this is a test infra problem.
closes #746