-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(systemextensionsctl): add functionality #597
base: dev
Are you sure you want to change the base?
feat(systemextensionsctl): add functionality #597
Conversation
test failed on ubuntu even though this was only set to darwin? |
I just had to change the base branch to |
Oops, didn't check that :/ |
On my side I am ready to merge, if tests pass (and they did) |
Would be good to have some tests before merging, if possible. |
legitimate bug in code, caught by tests. need to mull it over until I fix it, or if you know how to resolve the bug quickly I can just do as you suggest |
woot woot! tests are passing! |
For me having this as json is a huge step forward, so any schema changes are welcome |
tests have passed! feel free to review again @kellyjonbrazil |
Hi @georgettica - sorry I've been traveling quite a bit the past few months. I'll take a closer look soon and start working on wrapping up the next release. |
No rush or problem, just thought it was lost between the cracks |
No description provided.