Embedded Magnet Option #207
Conversation
|
There are two parameters that I would consider adding, please advise:
Also, there are some tests I need to fix, and probably a readme fix. |
EmperorArthur
left a comment
EmperorArthur
left a comment
There was a problem hiding this comment.
In addition to the in file comments, please add unit tests for this option, and any other hole option it can be combined with.
| chamfer = hole_options[4]; | ||
| supportless = hole_options[5]; | ||
| embedded = hole_options[6]; | ||
| embedded_extra_layers = 3; |
There was a problem hiding this comment.
Could you please move this to the Magnet/Screw constants section of "standard.scad". That file is where all constant / magic values live.
| translate([-magnet_radius,-magnet_radius * 0.15,0]) | ||
| cube([2*magnet_radius, magnet_radius * 0.3, embedded_depth]); | ||
| cylinder(h = embedded_depth, r=magnet_radius); | ||
| } |
There was a problem hiding this comment.
Given this is inside a difference(), have you confirmed if this works correctly with other options? If it is not supposed to be used with anything else, then you will need to add checks similar to those which currently exist for refined_hole.
2 participants
I added the embedded Magnet option. To use it, pause the printer like the Swedish Maker says. On a Bambu it's layer 12 right now. https://www.youtube.com/watch?v=p2bClWmKHRM&t=955s
The printer then prints around the part, and no glue is needed.