Add stacking lip notches #292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new stacking lip style (3) for standard lip with notch positions for alignment
Collaborator
|
Thanks for the work. The idea looks interesting, but I have not examined the code yet. Could you please rebase off of current main? V2.0 changed quite a bit and re-arranged things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new stacking lip style ($style_lip == 3) for standard stacking lip with notch positions for alignment
The geometry of the notch is added in module lipNotch in gridfinity-rebuilt-utility.scad
the notches are added inside gridfinityInit immediately after the outer wall is constructed and swept.
The notch placements are aligned to match standard and half-grid bins, whichever is configured.
block_cutter is slightly modified to understand the new $style_lip value of 3
The gridfinity-rebuilt-bins.scad file has this value (3) added to the comment used by the customizer for style_lip
This addresses feature request #219