fix: mutually exclusive map control menus + consistent split-mode menu styling#3547
Open
igorDykhta wants to merge 2 commits into
Open
fix: mutually exclusive map control menus + consistent split-mode menu styling#3547igorDykhta wants to merge 2 commits into
igorDykhta wants to merge 2 commits into
Conversation
Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local>
igorDykhta
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates kepler.gl’s map-control UI so overlapping dropdown menus (split/view-mode, 3D/globe, draw tools, locale) don’t stay open at the same time, and updates the split-view mode menu to use the shared toolbar UI with localized labels.
Changes:
- Add “mutually exclusive map controls” logic to
toggleMapControlUpdaterso opening one overlapping control closes the others. - Refactor
SplitMapButtonto keep its menu open state in Redux (mapControls.splitMap.active) and render options viaMapControlToolbar+ToolbarItem. - Add new localized tooltip strings for split-view mode labels (single/dual/swipe) across multiple locales.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/reducers/src/ui-state-updaters.ts | Adds a mutually-exclusive map-controls list and closes competing menus when opening one. |
| src/components/src/map/split-map-button.tsx | Moves split-mode menu state to Redux and uses the shared toolbar/menu components with i18n labels. |
| src/localization/src/translations/ru.ts | Adds split-view mode tooltip strings (single/dual/swipe). |
| src/localization/src/translations/pt.ts | Adds split-view mode tooltip strings (single/dual/swipe). |
| src/localization/src/translations/ja.ts | Adds split-view mode tooltip strings (single/dual/swipe). |
| src/localization/src/translations/fi.ts | Adds split-view mode tooltip strings (single/dual/swipe). |
| src/localization/src/translations/es.ts | Adds split-view mode tooltip strings (single/dual/swipe). |
| src/localization/src/translations/en.ts | Adds split-view mode tooltip strings (single/dual/swipe). |
| src/localization/src/translations/cn.ts | Adds split-view mode tooltip strings (single/dual/swipe). |
| src/localization/src/translations/ca.ts | Adds split-view mode tooltip strings (single/dual/swipe). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several map control menu issues:
singleView/dualView/swipeViewlabels for all supported locales.