added changes to support numpy.log1p op #21050
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@rkazants could you please review this PR :) |
pytest.ini
Outdated
| [pytest] | ||
| env = | ||
| KERAS_BACKEND=openvino |
There was a problem hiding this comment.
In the issue description it was mentioned that a pytest.ini file is to be created in the root of the cloned repo, should i still remove this file ?
There was a problem hiding this comment.
It was needed only for developer purpose but not for production. So please remove it.
There was a problem hiding this comment.
@rkazants sure, both the PRs would be fixed today
requirements.txt
Outdated
| @@ -7,7 +7,7 @@ tf2onnx | |||
| # Torch. | |||
| --extra-index-url https://download.pytorch.org/whl/cpu | |||
| torch==2.6.0+cpu | |||
| torch-xla==2.6.0;sys_platform != 'darwin' | |||
| #torch-xla==2.6.0;sys_platform != 'darwin' | |||
There was a problem hiding this comment.
need to revert this change
|
@Raghavyadav17, please run workflow for validation |
Hi @rkazants will make the necessary changes you mentioned. Any commands to trigger the workflow for validation ? |
|
hi @rkazants how do I run the workflow for validation ? |
requirements.txt
Outdated
| @@ -7,7 +7,7 @@ tf2onnx | |||
| # Torch. | |||
| --extra-index-url https://download.pytorch.org/whl/cpu | |||
| torch==2.6.0+cpu | |||
| torch-xla==2.6.0;sys_platform != 'darwin' | |||
There was a problem hiding this comment.
please revert this change. Not needed
| NumpyDtypeTest::test_log10 | ||
| NumpyDtypeTest::test_log1p | ||
|
|
||
| NumpyDtypeTest::test_log |
There was a problem hiding this comment.
please rebase to latest master
There was a problem hiding this comment.
please rebase to latest master
hi @rkazants will fix all the issues by today
| NumpyDtypeTest::test_log1p | ||
| NumpyDtypeTest::test_logaddexp | ||
| NumpyDtypeTest::test_log10 | ||
|
|
||
| NumpyDtypeTest::test_log |
There was a problem hiding this comment.
not correct. remove lines only corresponding to log1p
Based on the problem statement, implemented all the necessary changes in the codebase i.e
Fixes openvinotoolkit/openvino#29487