Skip to content

Fix Embedding test with ragged tensors on GPU. #21177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

hertschuh
Copy link
Collaborator

The loss needs to not have any non-compilable op.

The loss needs to not have any non-compilable op.
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.58%. Comparing base (1ea81a1) to head (e7090e9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21177   +/-   ##
=======================================
  Coverage   82.58%   82.58%           
=======================================
  Files         564      564           
  Lines       54359    54366    +7     
  Branches     8448     8448           
=======================================
+ Hits        44891    44898    +7     
  Misses       7393     7393           
  Partials     2075     2075           
Flag Coverage Δ
keras 82.39% <100.00%> (+<0.01%) ⬆️
keras-jax 63.80% <100.00%> (-0.01%) ⬇️
keras-numpy 58.92% <25.00%> (-0.01%) ⬇️
keras-openvino 32.92% <25.00%> (+<0.01%) ⬆️
keras-tensorflow 64.21% <100.00%> (-0.01%) ⬇️
keras-torch 63.89% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 17, 2025
@fchollet fchollet merged commit b840164 into keras-team:master Apr 17, 2025
11 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels Apr 17, 2025
@hertschuh hertschuh deleted the ragged_test_fit branch April 17, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants