Skip to content

bpf: Run deferred program freeing on system_dfl_long_wq - #8426

Open
kernel-patches-daemon-bpf-rc[bot] wants to merge 1 commit into
bpf-next_basefrom
series/1130518=>bpf-next
Open

bpf: Run deferred program freeing on system_dfl_long_wq#8426
kernel-patches-daemon-bpf-rc[bot] wants to merge 1 commit into
bpf-next_basefrom
series/1130518=>bpf-next

Conversation

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown

Pull request for series with
subject: bpf: Run deferred program freeing on system_dfl_long_wq
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 761214e
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: cfce77b
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 0bcca2a
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 5f30ac9
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 7ac6e1a
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 7c25590
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 2f2223a
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 5eb8921
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 426a6be
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: fcac2b4
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 8f876c7
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 0b10b94
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 6078126
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 457d4ec
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 7f333f8
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: e2baf9c
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 6655c40
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 363b15d
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 5b91f44
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 8295c27
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 11c1e83
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

1 similar comment
@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 11c1e83
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 7d008cd
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 8c7f55d
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 41c129f
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 2b1f9f6
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: e1d9b82
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 51476f6
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: 8b365b3
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

@kernel-patches-daemon-bpf-rc

Copy link
Copy Markdown
Author

Upstream branch: d114bb9
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1130518
version: 1

Destroying APT's seccomp BPF programs can spend over 20ms in arm64 JIT
text invalidation. bpf_jit_free() calls kick_all_cpus_sync(), which is
especially expensive on system with many CPUs.

schedule_work() uses a per-CPU workqueue, causing:

"""
[204351.169849] workqueue: bpf_prog_free_deferred hogged CPU for
>20000us 5 times, consider switching to WQ_UNBOUND
"""

This is triggered during a normal "sudo apt update -y"

Queue the cleanup on system_dfl_long_wq, the unbound queue intended for
long-running work, to avoid delaying concurrency-managed per-CPU
workers.

Signed-off-by: Richard Cheng <icheng@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant