bpf: Fix socket leaks around connect(AF_UNSPEC)+listen() - #8594
Open
kernel-patches-daemon-bpf-rc[bot] wants to merge 2 commits into
Open
bpf: Fix socket leaks around connect(AF_UNSPEC)+listen()#8594kernel-patches-daemon-bpf-rc[bot] wants to merge 2 commits into
kernel-patches-daemon-bpf-rc[bot] wants to merge 2 commits into
Conversation
Author
|
Upstream branch: e5fd3f5 |
kernel-patches-daemon-bpf-rc
Bot
force-pushed
the
bpf_base
branch
from
August 4, 2026 07:32
c953291 to
47219af
Compare
Author
|
Upstream branch: 7cd8645 |
kernel-patches-daemon-bpf-rc
Bot
force-pushed
the
series/1139204=>bpf
branch
from
August 4, 2026 07:33
e245c00 to
cc33f3b
Compare
Author
|
Upstream branch: 7cd8645 |
kernel-patches-daemon-bpf-rc
Bot
force-pushed
the
series/1139204=>bpf
branch
from
August 4, 2026 10:15
cc33f3b to
15c71a1
Compare
Author
|
Upstream branch: 31a420a |
kernel-patches-daemon-bpf-rc
Bot
force-pushed
the
series/1139204=>bpf
branch
from
August 5, 2026 20:39
15c71a1 to
7787b2b
Compare
kernel-patches-daemon-bpf-rc
Bot
force-pushed
the
bpf_base
branch
from
August 6, 2026 00:16
6d62329 to
ab5db42
Compare
Author
|
Upstream branch: 31a420a |
kernel-patches-daemon-bpf-rc
Bot
force-pushed
the
series/1139204=>bpf
branch
from
August 6, 2026 00:20
7787b2b to
21034fe
Compare
kernel-patches-daemon-bpf-rc
Bot
force-pushed
the
bpf_base
branch
from
August 6, 2026 23:41
ab5db42 to
bef3f93
Compare
Author
|
Upstream branch: 7a3c028 |
kernel-patches-daemon-bpf-rc
Bot
force-pushed
the
series/1139204=>bpf
branch
from
August 6, 2026 23:42
21034fe to
dadc39c
Compare
kernel-patches-daemon-bpf-rc
Bot
force-pushed
the
bpf_base
branch
from
August 7, 2026 15:35
bef3f93 to
0e8ddea
Compare
__bpf_sk_lookup() and bpf_sk_lookup() duplicate the same sk_to_full_sk() reqsk-to-listener upgrade. Extract it into a helper. Leave the currently unreachable WARN_ONCE as a defensive assert. No functional change. Signed-off-by: Michal Luczaj <mhal@rbox.co> Reviewed-by: Emil Tsalapatis <emil@etsalapatis.com> Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
Lookup helpers gate whether to acquire a socket reference on sk_is_refcounted(), a check re-evaluated at release. An established socket refcounted at acquire time can gain SOCK_RCU_FREE via connect(AF_UNSPEC)+listen() before release runs; the release-side re-check then reads sk_is_refcounted() == false and skips the put. The reference leaks. Make acquire and release unconditional and symmetric: always take a reference, always put it. Adapt sk_select_reuseport(). Fixes: 6acc9b4 ("bpf: Add helper to retrieve socket in BPF") Fixes: 64d8529 ("bpf: Allow bpf_map_lookup_elem for SOCKMAP and SOCKHASH") Reported-by: Sashiko <sashiko-bot@kernel.org> Closes: https://lore.kernel.org/bpf/20260701235552.2B0AA1F00A3F@smtp.kernel.org/ Signed-off-by: Michal Luczaj <mhal@rbox.co> Reviewed-by: Emil Tsalapatis <emil@etsalapatis.com>
Author
|
Upstream branch: a13307e |
kernel-patches-daemon-bpf-rc
Bot
force-pushed
the
series/1139204=>bpf
branch
from
August 7, 2026 15:36
dadc39c to
4c23290
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Fix socket leaks around connect(AF_UNSPEC)+listen()
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1139204