bpf: Compare iterator types during state pruning - #8697
Closed
kernel-patches-daemon-bpf-rc[bot] wants to merge 2 commits into
Closed
bpf: Compare iterator types during state pruning#8697kernel-patches-daemon-bpf-rc[bot] wants to merge 2 commits into
kernel-patches-daemon-bpf-rc[bot] wants to merge 2 commits into
Conversation
An iterator stack slot can be MEM_RCU or PTR_UNTRUSTED. These states must not be equal, or the verifier can prune an unsafe path. Compare the pointer type for STACK_ITER slots. Fixes: dfab99d ("bpf: teach the verifier to enforce css_iter and task_iter in RCU CS") Signed-off-by: Ning Ding <dingning04@gmail.com> Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Add a path where RCU protection reaches zero and then starts again. The iterator is untrusted after this gap and must be rejected. Signed-off-by: Ning Ding <dingning04@gmail.com>
Author
|
Upstream branch: d114bb9 |
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1143786 irrelevant now. Closing PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Compare iterator types during state pruning
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1143786