kpd: allow to override the contact in notification emails - #63
Open
rppt wants to merge 2 commits into
Open
Conversation
The EMAIL_TEMPLATE_BASE hardcodes Meta Kernel CI team as the contact for questions and feedback. To use KPD outside Meta CI, add optional configuration options "contact_name" and "contact_email" to the email configuration block and use those configuration options when constructing the email body in furnish_ci_email_body(). When these options are not present in a configuration file, backward compatible defaults are used. Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Ensure the default contact remains backward compatible and configured contact details are used in notification emails. Assisted-by: Copilot:gpt-5.6-sol Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notification emails always direct questions to the Meta Kernel CI team, which is not appropriate for other KPD deployments.
Add optional
contact_nameandcontact_emailsettings while retaining the Meta defaults when they are absent. Add tests for the default and configured contacts.Tested with:
python -m unittest tests.test_config tests.test_branch_worker