refactor: remove the theme and chartColor from schemes #7296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we sure we want to remove scheme from charts @elevatebart? It's not related to theme colors, it's basically default scheme: And custom The second screenshot is using the |
|
Can we have @Nico-Kestra eyes on this one. This extra theme conflicts with a contributor ticket If a perfect match is always required, we need to have the colorblind colors in both places. Maybe a 3rd high contrast theme? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we dont use the "scheme" for chart colors, we should not have it in the code or in the config.
This PR removes all the config that does not work anymore.