Skip to content

Fix "\/" handling#1

Closed
2shortplanks wants to merge 2 commits into
kevcenteno:masterfrom
2shortplanks:markf/fix-backslash-forwardslash
Closed

Fix "\/" handling#1
2shortplanks wants to merge 2 commits into
kevcenteno:masterfrom
2shortplanks:markf/fix-backslash-forwardslash

Conversation

@2shortplanks
Copy link
Copy Markdown

No description provided.

According to rfc7159 you can write "\/" to mean literal forward slash

jsonlint doesn't currently seem to know about this.  So it turns "\/" into
"\\/" which is totally wrong (that means literal-backslash literal
forward slash.)

This change changes "\/" into plain old "/".
@oschwald
Copy link
Copy Markdown

There is also zaach#54, which seems to handle a few more cases.

@2shortplanks
Copy link
Copy Markdown
Author

Yeah, that seems way more comprehensive.

I leave this up to @kevcenteno which way he wants to go.

  1. Take this minor fix to fix just this issue that I'm seeing
  2. Take Fix string escapes. (issue #37) zaach/jsonlint#54
  3. See if there's another fork of jsonlint that the changes in this fork should be rebased off of
  4. None of the above and just take the dog for a walk

@kevcenteno
Copy link
Copy Markdown
Owner

I just washed the dog and created a separate PR that takes zaach#54

@kevcenteno kevcenteno closed this Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants