Make all abstract base class interfaces concepts and use them instead #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also tighten the requirements for check_trigger to be a const member function as there is no real reason to have it mutate anything.
There is no current need to customize this as all our models use the same.
tmadlener
commented
Dec 18, 2025
| /** convert the local spacepoints to global spacepoints inside sensitive | ||
| * volumes | ||
| */ | ||
| { t.localToGlobal(aFastTrack, spacepoints) } -> std::same_as<void>; |
Member
Author
There was a problem hiding this comment.
The ones that are void should be harmonized. Some use same_as<void> others do not specify anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
HitMakeras a customization point from theFastMLModelsince we always use the same in any case at the moment.ENDRELEASENOTES