Trigger fix#3
Open
peter-mckeown wants to merge 3 commits intomainfrom
Open
Conversation
tmadlener
reviewed
Jun 3, 2025
Member
tmadlener
left a comment
There was a problem hiding this comment.
Is there an easy way to check whether this works. Mainly to avoid future regressions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Copied from Original Repo MR! 25
As spotted by Anatolii, there are (rare) edge cases close to a geometrical region excluded from fast sim where secondaries created in a full sim shower can cross the trigger boundary and cause unwanted fast sim triggers inside the calorimeter. This MR proposes a fix for this with two important steps:
model.RegionNameinscripts/ddsim_steer.py).E.g. for the ECAL Barrel of
ILD_l5_o1_v02.xmlthis would mean creating a local copy of k4geo and modifyingSEcal06_hybrid_Barrel.xmlaccordingly:src/OctogonalBarrelTrigger.cc)Validation checks performed so far (with 2025-01-28 key4hep release):
particle gun into calo in FastSim region
position: (0, 0, 0), direction: (0 1 0), particle: gamma, energy: 50 GeV
Results: Triggers Fast Sim (expected behavior)
particle gun inside calo (firing backwards) in FastSim region
position: (0, 1860, 0), direction: 0 -1 0, particle: gamma, energy: 50 GeV
Results: Does not trigger Fast Sim (expected behavior)
particle gun into calo region excluded from FastSim (corner of barrel)
position: (0, 0, 0), direction: (-0.4152 1 0), particle: gamma, energy: 50 GeV
Results: Does not trigger Fast Sim (expected behavior)