-
Notifications
You must be signed in to change notification settings - Fork 3
Hadrons merge #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a7799db to
9251bbe
Compare
tmadlener
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good in general. there are a few (more or less) minor comments below for some specifics.
Some other general remarks:
- There is quite a few places where commented code is still included. I would have a preference for removing that
- There are a few places where
std::coutis used. Can we change those to use the dd4hep logging facilities?
In the end the PionCloudsModel is rather similar to the CaloCloudsTwoAngleModel and we could think about trying to factor out the similarities of those into a separate class. But that is definitely not in the scope of this PR for me.
Co-authored-by: Thomas Madlener <[email protected]>
Co-authored-by: Thomas Madlener <[email protected]>
Co-authored-by: Thomas Madlener <[email protected]>
|
Thanks a lot for the review @tmadlener ! I think all your comments should be resolved now- I also went through and replaced all instances where |
tmadlener
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally managed to get around to resolving the merge conflict here. I think it was straight forward enough for me to not mess up, but a second look would still be greatly appreciated.
|
@tmadlener looks good to go to me |
Splitting part 1 from MR! 4:
Adds the possibility to configure models for hadronic shower simulation (including placement in ECAL + HCAL). So far testing has been performed for single particle events loaded from HDF5