-
Notifications
You must be signed in to change notification settings - Fork 13
[WIP] Acts Geo Gen3 DD4hep conversion #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tmadlener
wants to merge
22
commits into
key4hep:main
Choose a base branch
from
tmadlener:dd4hep-acts-gen3-geo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the Acts downstream assumes a shared_ptr, so we might as well return one from here
Make the ActsGeoSvc implementation return a constant magnetic field along for now.
Currently failing at properly stacking on the outermost layers of the Endcap without (seemingly irrelevant?) overlap in r
bfc300c to
bccc01e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
exactly as it appears between the two bold lines
ENDRELEASENOTES
This is a work in progress with the main purpose of being able to share ongoing efforts. So far the efforts focus on getting (parts) of the
MAIA_v0geometry conversion tested and evaluated against upstream work happening at currently living on https://github.com/paulgessinger/acts/tree/feat/dd4hep-gen3