-
Notifications
You must be signed in to change notification settings - Fork 31
Upstream SequenceLoader from ILDConfig #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tmadlener
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a small test for this? I think it should be fairly straight forward with the functional examples that we already have to make one where we
- use the
ExampleFunctionalProducerto create some MCParticle collection and put that into a (trivial) sequence in a separate file - Load that sequence in the main config and run the
ExampleFunctionalConsumerfrom there (or if we go for really fancy put that into a second file and load that as well).
|
@tmadlener I added a test but accessing the sequence became a bit ugly, maybe you have a better idea... This is about as much time as I can invest at the moment. |
|
Thanks for adding the test. For now I have added a slightly more generic version of I have also added a bit of documentation to make sure that it's clearly stated that the sequence will be loaded relative to the working directory unless given as an absolute "path". The one option that would make this possible otherwise would be to add an optional |
|
Are we still waiting on something here? Should we still take a look at how ATLAS and LHCb deal with this? |
BEGINRELEASENOTES
SequenceLoaderfrom ILDConfig, it is used by both CLD and ILD.ENDRELEASENOTES