Volume tutorial: Refer to an "upcoming" feature, rather than an "experimental" one #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also makes the link actually link to something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Make a volume button toggle the flashlight on the lockscreen" tutorial includes the following sentence (complete with the broken link).
My best guess is that this is referring to the unmerged
feature/1394-kernel-remappingbranch, and not a feature that has already been merged, but has to be opted into (like I had assumed originally). The edit I made in this PR to change the wording from "experimental" feature to "upcoming" feature and make the link point to keymapperorg/KeyMapper#1394 reflects that assumption, so let me know if it's wrong and I can update the PR.