Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix only the first log file is rotated #158

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Fix only the first log file is rotated #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,15 @@ function proceed_app(app, force) {
}
}

function has_same_logs(app1, app2) {
// return true only if all log paths are identical
if (!app1 || !app2) return false;
if (app1.pm2_env.pm_out_log_path !== app2.pm2_env.pm_out_log_path) return false;
if (app1.pm2_env.pm_err_log_path !== app2.pm2_env.pm_err_log_path) return false;
if (app1.pm2_env.pm_log_path !== app2.pm2_env.pm_log_path) return false;
return true;
}

// Connect to local PM2
pm2.connect(function(err) {
if (err) return console.error(err.stack || err);
Expand All @@ -205,8 +214,8 @@ pm2.connect(function(err) {
// if its a module and the rotate of module is disabled, ignore
if (typeof(app.pm2_env.axm_options.isModule) !== 'undefined' && !ROTATE_MODULE) return ;

// if apps instances are multi and one of the instances has rotated, ignore
if(app.pm2_env.instances > 1 && appMap[app.name]) return;
// if apps instances are multi and the logs of instances are combined, ignore
if(app.pm2_env.instances > 1 && has_same_logs(appMap[app.name], app)) return;

appMap[app.name] = app;

Expand Down