Merge pull request #212 from kgoldfeld/issue-208-improve-addCorGen

Fixing nvars in addCorGen

R/add_correlated_data.R

@@ -317,7 +317,6 @@ addCorFlex <- function(dt, defs, rho = 0, tau = NULL, corstr = "cs",
 #' # Long example
 #'
 #' def <- defData(varname = "xbase", formula = 5, variance = .4, dist = "gamma", id = "cid")
-#' def <- defData(def, "nperiods", formula = 3, dist = "noZeroPoisson")
 #'
 #' def2 <- defDataAdd(
 #'   varname = "p", formula = "-3+.2*period + .3*xbase",
@@ -328,6 +327,11 @@ addCorFlex <- function(dt, defs, rho = 0, tau = NULL, corstr = "cs",
 #'
 #' dtLong <- addPeriods(dt, idvars = "cid", nPeriods = 3)
 #' dtLong <- addColumns(def2, dtLong)
+#' 
+#' addCorGen(
+#'   dtOld = dtLong, idvar = "cid", nvars = NULL, rho = .7, corstr = "cs",
+#'   dist = "binary", param1 = "p"
+#' )
 #'
 #' @concept correlated
 #' @export
@@ -468,7 +472,8 @@ addCorGen <- function(dtOld, nvars=NULL, idvar = "id", rho=NULL, corstr=NULL, co
   }
 
   dtTemp[, seq_ := 1:.N, keyby = .id]
-
+  nvars <- dtTemp[.id == 1, .N] # only permits case where number of records per id is the same
+
   ####
 
   if (method == "copula") {