Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding log link to binary dist #231

Merged
merged 3 commits into from
Jun 29, 2024

Conversation

kgoldfeld
Copy link
Owner

No description provided.

@kgoldfeld kgoldfeld linked an issue Jun 28, 2024 that may be closed by this pull request
@kgoldfeld
Copy link
Owner Author

@assignUser Not sure why the usual system checks did not run. Does something need to be updated?

@assignUser
Copy link
Collaborator

assignUser commented Jun 29, 2024

Huh, that's weird... I tried re-running a previous job to test that there is no issue with the tags for the runners or something but that seems fine. Just try and push another commit to trigger it again?

edit: I did that, it seems to work 🤷

NEWS.md Outdated Show resolved Hide resolved
@kgoldfeld
Copy link
Owner Author

Yes - checks have been triggered.

@kgoldfeld
Copy link
Owner Author

@assignUser Assuming it passes all the checks, are you OK with my merging this quite minor but useful change?

Copy link

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 3978738 is merged into main:

  • ✔️define_data: 17.3ms -> 17.3ms [-0.84%, +1.09%]
  • ✔️dist_beta: 218ms -> 219ms [-2.2%, +3.58%]
  • ✔️dist_binary: 8.73ms -> 8.7ms [-2.7%, +2.01%]
  • ✔️dist_binomial: 13.2ms -> 13.2ms [-1.96%, +1.75%]
  • ❗🐌dist_categorical: 57.7ms -> 58.6ms [+0.8%, +2.5%]
  • ✔️dist_exponential: 8.86ms -> 8.83ms [-1.54%, +1.05%]
  • ✔️dist_gamma: 16.3ms -> 16.3ms [-0.56%, +0.24%]
  • ✔️dist_mixture: 232ms -> 229ms [-3.98%, +1.4%]
  • ✔️dist_normal: 10.6ms -> 11.1ms [-6.46%, +16.41%]
  • ✔️gen_all_dists: 50ms -> 49.8ms [-2.86%, +2.21%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@kgoldfeld kgoldfeld merged commit 8ee0284 into main Jun 29, 2024
9 checks passed
@kgoldfeld kgoldfeld deleted the 230-add-log-link-option-for-binary-data-generation branch June 29, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add log link option for binary data generation
2 participants