Skip to content

Update scalafmt-core to 3.8.4 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Update scalafmt-core to 3.8.4 #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed5719e
Update scalafmt-core to 3.8.4
kijuky Jan 14, 2025
f7ff326
Reformat with scalafmt 3.8.4
kijuky Jan 14, 2025
85df90f
Add 'Reformat with scalafmt 3.8.4' to .git-blame-ignore-revs
kijuky Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .git-blame-ignore-revs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Scala Steward: Reformat with scalafmt 3.8.4
f7ff32694ee0f9cc59e0b9d33c1f9274be7034d8
2 changes: 1 addition & 1 deletion .scalafmt.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version = 3.8.3
version = 3.8.4
preset = IntelliJ
runner.dialect = scala212

Expand Down
17 changes: 6 additions & 11 deletions zio/src/test/scala/io/github/kijuky/zio/jira/FakeIssueRestClient.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,12 @@ case class FakeIssueRestClient(
doGetCreateIssueMetadata: GetCreateIssueMetadataOptions => Seq[CimProject] =
null,
doCreateIssues: Seq[IssueInput] => BulkOperationResult[BasicIssue] = null,
doGetCreateIssueMetaProjectIssueTypes: (
String,
Long,
Int
) => Page[IssueType] = null,
doGetCreateIssueMetaFields: (
String,
String,
Long,
Int
) => Page[CimFieldInfo] = null,
doGetCreateIssueMetaProjectIssueTypes: (String, Long, Int) => Page[
IssueType
] = null,
doGetCreateIssueMetaFields: (String, String, Long, Int) => Page[
CimFieldInfo
] = null,
doGetIssue: String => Issue = null,
doGetIssueDetail: (String, Seq[Expandos]) => Issue = null,
doDeleteIssue: (String, Boolean) => Unit = null,
Expand Down
66 changes: 22 additions & 44 deletions zio/src/test/scala/io/github/kijuky/zio/jira/JiraIssueRepoImplSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ object JiraIssueRepoImplSpec extends ZIOSpecDefault:
Seq(issue) = actual
yield Chunk(test("課題を返すこと"):
assertTrue:
issue.summary == "Fake Issue"
)
issue.summary == "Fake Issue")
.provide(ZLayer:
val issues = Seq(FakeIssue(summary = "Fake Issue"))
val searchClient = FakeSearchRestClient(
Expand All @@ -23,60 +22,53 @@ object JiraIssueRepoImplSpec extends ZIOSpecDefault:
)
val restClient = FakeJiraRestClient(searchClient = searchClient)
for service <- ZIO.succeed(FakeJiraService(restClient = restClient))
yield JiraIssueRepoImpl(service)
)
yield JiraIssueRepoImpl(service))

suite("searchJqlが課題を返さなかった場合"):
for
sut <- ZIO.service[JiraIssueRepoImpl]
actual <- sut.list(123456)
yield Chunk(test("課題を返さないこと"):
assertTrue:
actual.isEmpty
)
actual.isEmpty)
.provide(ZLayer:
val searchClient = FakeSearchRestClient(
doGetFilterId = _ => FakeFilter(),
doSearchJql = _ => FakeSearchResult(issues = Nil)
)
val restClient = FakeJiraRestClient(searchClient = searchClient)
for service <- ZIO.succeed(FakeJiraService(restClient = restClient))
yield JiraIssueRepoImpl(service)
)
yield JiraIssueRepoImpl(service))

suite("searchJqlでエラーが発生した場合"):
for
sut <- ZIO.service[JiraIssueRepoImpl]
isFailure <- sut.list(123456).isFailure
yield Chunk(test("失敗すること"):
assertTrue:
isFailure
)
isFailure)
.provide(ZLayer:
val searchClient = FakeSearchRestClient(
doGetFilterId = _ => FakeFilter(),
doSearchJql = _ => throw RuntimeException()
)
val restClient = FakeJiraRestClient(searchClient = searchClient)
for service <- ZIO.succeed(FakeJiraService(restClient = restClient))
yield JiraIssueRepoImpl(service)
)
yield JiraIssueRepoImpl(service))

suite("getFilterでエラーが発生した場合"):
for
sut <- ZIO.service[JiraIssueRepoImpl]
isFailure <- sut.list(123456).isFailure
yield Chunk(test("失敗すること"):
assertTrue:
isFailure
)
isFailure)
.provide(ZLayer:
val searchClient =
FakeSearchRestClient(doGetFilterId = _ => throw RuntimeException())
val restClient = FakeJiraRestClient(searchClient = searchClient)
for service <- ZIO.succeed(FakeJiraService(restClient = restClient))
yield JiraIssueRepoImpl(service)
)
yield JiraIssueRepoImpl(service))

suiteAll("list(jql)"):
suite("searchJqlが課題を返した場合"):
Expand All @@ -86,51 +78,45 @@ object JiraIssueRepoImplSpec extends ZIOSpecDefault:
Seq(issue) = actual
yield Chunk(test("課題を返すこと"):
assertTrue:
issue.summary == "Fake Issue"
)
issue.summary == "Fake Issue")
.provide(ZLayer:
val issues = Seq(FakeIssue(summary = "Fake Issue"))
val searchClient = FakeSearchRestClient(doSearchJql =
_ => FakeSearchResult(issues = issues)
)
val restClient = FakeJiraRestClient(searchClient = searchClient)
for service <- ZIO.succeed(FakeJiraService(restClient = restClient))
yield JiraIssueRepoImpl(service)
)
yield JiraIssueRepoImpl(service))

suite("searchJqlが課題を返さなかった場合"):
for
sut <- ZIO.service[JiraIssueRepoImpl]
actual <- sut.list("filterId = 123456")
yield Chunk(test("課題を返さないこと"):
assertTrue:
actual.isEmpty
)
actual.isEmpty)
.provide(ZLayer:
val searchClient =
FakeSearchRestClient(doSearchJql =
_ => FakeSearchResult(issues = Nil)
)
val restClient = FakeJiraRestClient(searchClient = searchClient)
for service <- ZIO.succeed(FakeJiraService(restClient = restClient))
yield JiraIssueRepoImpl(service)
)
yield JiraIssueRepoImpl(service))

suite("searchJqlでエラーが発生した場合"):
for
sut <- ZIO.service[JiraIssueRepoImpl]
isFailure <- sut.list(123456).isFailure
yield Chunk(test("失敗すること"):
assertTrue:
isFailure
)
isFailure)
.provide(ZLayer:
val searchClient =
FakeSearchRestClient(doSearchJql = _ => throw RuntimeException())
val restClient = FakeJiraRestClient(searchClient = searchClient)
for service <- ZIO.succeed(FakeJiraService(restClient = restClient))
yield JiraIssueRepoImpl(service)
)
yield JiraIssueRepoImpl(service))

suiteAll("save"):
suite("updateIssueが正常終了した場合"):
Expand All @@ -141,14 +127,12 @@ object JiraIssueRepoImplSpec extends ZIOSpecDefault:
.isSuccess
yield Chunk(test("正常終了すること"):
assertTrue:
isSuccess
)
isSuccess)
.provide(ZLayer:
val issueClient = FakeIssueRestClient(doUpdateIssue = (_, _) => ())
val restClient = FakeJiraRestClient(issueClient = issueClient)
for service <- ZIO.succeed(FakeJiraService(restClient = restClient))
yield JiraIssueRepoImpl(service)
)
yield JiraIssueRepoImpl(service))

suite("updateIssueが異常終了した場合"):
for
Expand All @@ -158,16 +142,14 @@ object JiraIssueRepoImplSpec extends ZIOSpecDefault:
.isFailure
yield Chunk(test("異常終了すること"):
assertTrue:
isFailure
)
isFailure)
.provide(ZLayer:
val issueClient = FakeIssueRestClient(doUpdateIssue =
(_, _) => throw RuntimeException()
)
val restClient = FakeJiraRestClient(issueClient = issueClient)
for service <- ZIO.succeed(FakeJiraService(restClient = restClient))
yield JiraIssueRepoImpl(service)
)
yield JiraIssueRepoImpl(service))

suiteAll("transition"):
suite("transitionが正常終了した場合"):
Expand All @@ -176,28 +158,24 @@ object JiraIssueRepoImplSpec extends ZIOSpecDefault:
isSuccess <- sut.transition(FakeJiraIssue(), 123).isSuccess
yield Chunk(test("正常終了すること"):
assertTrue:
isSuccess
)
isSuccess)
.provide(ZLayer:
val issueClient = FakeIssueRestClient(doTransitionIssue = (_, _) => ())
val restClient = FakeJiraRestClient(issueClient = issueClient)
for service <- ZIO.succeed(FakeJiraService(restClient = restClient))
yield JiraIssueRepoImpl(service)
)
yield JiraIssueRepoImpl(service))

suite("transitionが異常終了した場合"):
for
sut <- ZIO.service[JiraIssueRepoImpl]
isFailure <- sut.transition(FakeJiraIssue(), 123).isFailure
yield Chunk(test("異常終了すること"):
assertTrue:
isFailure
)
isFailure)
.provide(ZLayer:
val issueClient = FakeIssueRestClient(doTransitionIssue =
(_, _) => throw RuntimeException()
)
val restClient = FakeJiraRestClient(issueClient = issueClient)
for service <- ZIO.succeed(FakeJiraService(restClient = restClient))
yield JiraIssueRepoImpl(service)
)
yield JiraIssueRepoImpl(service))
12 changes: 4 additions & 8 deletions zio/src/test/scala/io/github/kijuky/zio/jira/JiraUserRepoImplSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,28 +13,24 @@ object JiraUserRepoImplSpec extends ZIOSpecDefault:
Some(user) = actual: @unchecked
yield Chunk(test("ユーザーを返すこと"):
assertTrue:
user.name == "test-user"
)
user.name == "test-user")
.provide(ZLayer:
val userClient =
FakeUserRestClient(doGetUser = _ => FakeUser(name = "test-user"))
val restClient = FakeJiraRestClient(userClient = userClient)
for service <- ZIO.succeed(FakeJiraService(restClient = restClient))
yield JiraUserRepoImpl(service)
)
yield JiraUserRepoImpl(service))

suite("getUserがエラーになった場合"):
for
sut <- ZIO.service[JiraUserRepoImpl]
isFailure <- sut.findByName("test-user").isFailure
yield Chunk(test("失敗すること"):
assertTrue:
isFailure
)
isFailure)
.provide(ZLayer:
val userClient =
FakeUserRestClient(doGetUser = _ => throw RuntimeException())
val restClient = FakeJiraRestClient(userClient = userClient)
for service <- ZIO.succeed(FakeJiraService(restClient = restClient))
yield JiraUserRepoImpl(service)
)
yield JiraUserRepoImpl(service))
Loading